131 lines
3.6 KiB
ReStructuredText
131 lines
3.6 KiB
ReStructuredText
============
|
|
Contributing
|
|
============
|
|
|
|
Contributions are welcome, and they are greatly appreciated! Every
|
|
little bit helps, and credit will always be given.
|
|
|
|
You can contribute in many ways:
|
|
|
|
Types of Contributions
|
|
----------------------
|
|
|
|
Report Bugs
|
|
~~~~~~~~~~~
|
|
|
|
Report bugs at https://github.com/dethos/django-cryptolock/issues.
|
|
|
|
If you are reporting a bug, please include:
|
|
|
|
* Your operating system name and version.
|
|
* Any details about your local setup that might be helpful in troubleshooting.
|
|
* Detailed steps to reproduce the bug.
|
|
|
|
Fix Bugs
|
|
~~~~~~~~
|
|
|
|
Look through the GitHub issues for bugs. Anything tagged with "bug"
|
|
is open to whoever wants to implement it.
|
|
|
|
Implement Features
|
|
~~~~~~~~~~~~~~~~~~
|
|
|
|
Look through the GitHub issues for features. Anything tagged with "feature"
|
|
is open to whoever wants to implement it.
|
|
|
|
Write Documentation
|
|
~~~~~~~~~~~~~~~~~~~
|
|
|
|
Django-Cryptolock could always use more documentation, whether as part of the
|
|
official Django-Cryptolock docs, in docstrings, or even on the web in blog posts,
|
|
articles, and such.
|
|
|
|
Submit Feedback
|
|
~~~~~~~~~~~~~~~
|
|
|
|
The best way to send feedback is to file an issue at https://github.com/dethos/django-cryptolock/issues.
|
|
|
|
If you are proposing a feature:
|
|
|
|
* Explain in detail how it would work.
|
|
* Keep the scope as narrow as possible, to make it easier to implement.
|
|
* Remember that this is a volunteer-driven project, and that contributions
|
|
are welcome :)
|
|
|
|
Get Started!
|
|
------------
|
|
|
|
Ready to contribute? Here's how to set up `django-cryptolock` for local development.
|
|
|
|
1. Fork the `django-cryptolock` repo on GitHub.
|
|
2. Clone your fork locally::
|
|
|
|
$ git clone git@github.com:your_name_here/django-cryptolock.git
|
|
|
|
3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development::
|
|
|
|
$ mkvirtualenv django-cryptolock
|
|
$ cd django-cryptolock/
|
|
$ pip install -r requirements_dev.txt -r requirements_test.txt
|
|
|
|
4. Create a branch for local development::
|
|
|
|
$ git checkout -b name-of-your-bugfix-or-feature
|
|
|
|
Now you can make your changes locally.
|
|
|
|
5. When you're done making changes, check that your changes pass ``black`` and the
|
|
tests, including testing other Python versions with ``tox``:
|
|
|
|
$ black --check django_cryptolock
|
|
$ make test
|
|
$ make test-all
|
|
|
|
To get black and tox, just pip install them into your virtualenv.
|
|
|
|
6. If your changes are visible to the user, you can add a demo for them to the
|
|
example project.
|
|
|
|
7. Commit your changes and push your branch to GitHub::
|
|
|
|
$ git add .
|
|
$ git commit -m "Your detailed description of your changes."
|
|
$ git push origin name-of-your-bugfix-or-feature
|
|
|
|
8. Submit a pull request through the GitHub website.
|
|
|
|
|
|
Running tests for specific environments
|
|
---------------------------------------
|
|
|
|
Do want to test only a specific python version / django version locally?
|
|
|
|
You can use tox directly::
|
|
|
|
::
|
|
|
|
source <YOURVIRTUALENV>/bin/activate
|
|
(myenv) $ pip install tox
|
|
(myenv) $ tox -e <your-python-version>-django-<22_or_30>
|
|
|
|
|
|
Pull Request Guidelines
|
|
-----------------------
|
|
|
|
Before you submit a pull request, check that it meets these guidelines:
|
|
|
|
1. The pull request should include tests.
|
|
2. If the pull request adds functionality, the docs should be updated. Put
|
|
your new functionality into a function with a docstring, and add the
|
|
feature to the list in README.rst.
|
|
3. The pull request should work for Python 3.6, 3.7 and 3.8. Check
|
|
https://travis-ci.org/dethos/django-cryptolock/pull_requests
|
|
and make sure that the tests pass for all supported Python versions.
|
|
|
|
Tips
|
|
----
|
|
|
|
To run a subset of tests::
|
|
|
|
$ pytest tests/test_models.py
|